-
-
Notifications
You must be signed in to change notification settings - Fork 111
fix: session hooks in referenced library projects not executing #4599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InfrastructureGenerator was not including project-to-project references (CompilationReference) when generating Assembly.Load() calls. During IDE design-time builds, project references are represented as CompilationReference objects rather than PortableExecutableReference, causing the library's module initializers (which register hooks) to not be triggered early enough. Renamed HasPhysicalLocation to IsLoadableAtRuntime and simplified the logic to accept any assembly with a corresponding reference, since all referenced assemblies will be available at runtime. Fixes #4583
This was referenced Jan 29, 2026
This was referenced Feb 2, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4583 -
[Before(TestSession)]and[After(TestSession)]hooks defined in referenced library projects were not executing.Problem
The
InfrastructureGeneratorgenerates code to load referenced assemblies early (to trigger their module initializers which register hooks). However, theHasPhysicalLocationcheck was too restrictive:This only accepted
PortableExecutableReferenceobjects. During IDE design-time builds, project-to-project references are represented asCompilationReferenceobjects. The incremental generator may cache results from these builds, resulting in missingAssembly.Load()calls for library projects.Solution
HasPhysicalLocationtoIsLoadableAtRuntimeto better reflect its purposeTest Plan
LibraryTestSessionHooksclass toTUnit.TestProject.Librarywith[Before(TestSession)]and[After(TestSession)]hooksLibraryTestSessionHookTestsinTUnit.TestProjectto verify the library's hooks executedotnet run -- --treenode-filter "/*/*/LibraryTestSessionHookTests/*"