-
-
Notifications
You must be signed in to change notification settings - Fork 111
fix: source generator benchmarks were running other generators #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomhurst
merged 1 commit into
thomhurst:main
from
TimothyMakkison:fix_benchmark_pollution
Feb 1, 2026
Merged
fix: source generator benchmarks were running other generators #4640
thomhurst
merged 1 commit into
thomhurst:main
from
TimothyMakkison:fix_benchmark_pollution
Feb 1, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean, focused fix that correctly addresses the benchmark pollution issue. The single-line change using
|
This was referenced Feb 3, 2026
Merged
Closed
This was referenced Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like when I'd run one benchmark it would run other source generators, giving a misleading time. For instance trying to benchmark
StaticPropertyInitializationGeneratorwould also runTestMetadataGeneratorand vice versa. You can prove this by changing all the predicates to false inTestMetadataGenerator, low and beholdStaticPropertyInitializationGeneratorwould suddenly run much faster.Strangely it doesn't happen to all generators, for instance
InfrastructureGeneratoronly runs itself when benchmarked, making it harder for me to spot the issue 😠Should solve the issue in #4639 / #4624 - I suspect I was consistently getting a faster time on the benchmarks because I was experimenting with
TestMetadataGenerator, not expecting it to affect an unrelated source generatorStaticPropertyInitializationGenerator
TestMetadataGenerator
AotConverter