Skip to content

feat: add DynamicTestsGeneratorIncrementalTests#4673

Merged
thomhurst merged 1 commit intothomhurst:mainfrom
TimothyMakkison:dynamic_generator_test
Feb 6, 2026
Merged

feat: add DynamicTestsGeneratorIncrementalTests#4673
thomhurst merged 1 commit intothomhurst:mainfrom
TimothyMakkison:dynamic_generator_test

Conversation

@TimothyMakkison
Copy link
Contributor

Add tests to verify that DynamicTestsGenerator uses incremental caching

@claude
Copy link
Contributor

claude bot commented Feb 6, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

This PR adds solid incremental generator testing following the established patterns from other generator tests in the codebase. The changes correctly:

  • Add tracking name constant for test observability
  • Follow the same pipeline structure as MethodAssertionGenerator
  • Verify all three key incremental scenarios (cache hit, modification, and new addition)
  • Maintain consistency with existing incremental test patterns

The implementation aligns with TUnit's performance-first principle by ensuring the DynamicTestsGenerator properly leverages incremental compilation.

@thomhurst thomhurst merged commit d92e158 into thomhurst:main Feb 6, 2026
8 of 10 checks passed
This was referenced Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants