-
-
Notifications
You must be signed in to change notification settings - Fork 111
Treat Type and MemberInfo as well-known types in structural equivalency comparisons #4701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith Type properties Treat System.Type and System.Reflection.MemberInfo as well-known types in structural equivalency comparisons, comparing by equality rather than structural decomposition. This prevents crashes from Type properties like DeclaringMethod that throw when accessed on non-generic-parameter types. Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix InvalidOperationException in IsEquivalentTo for records
Treat Type and MemberInfo as well-known types in structural equivalency comparisons
Feb 7, 2026
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a well-crafted bug fix that:
|
This was referenced Feb 10, 2026
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsEquivalentTothrowsInvalidOperationExceptionwhen comparing records withTypeproperties.RuntimeType.DeclaringMethod(among others) throws when accessed on non-generic-parameter types, and the structural comparison walks all public properties.Changes
TypeHelper.IsPrimitiveOrWellKnownType: Addedtypeof(Type).IsAssignableFrom(type)andtypeof(MemberInfo).IsAssignableFrom(type)so reflection types are compared by equality rather than structurally decomposed. UsesIsAssignableFromto catch runtime subtypes likeRuntimeType.IsEquivalentTo_TypeProperty_Testscovering same-instance, equal, and differentTypeproperty scenarios.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.