fix: consistent test time tracking #4723
Merged
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…headline duration Before hooks were already excluded from test duration (TestStart set after Before hooks), but After hooks were included (TestEnd only set after After hooks completed). This made reported test times inconsistent and inflated. Now TestEnd is set immediately after the test body finishes (before After hooks run), and both Before/After test-level hooks are recorded as step timings via Timings.Record() for granular visibility. EndTime assignments in TestRunner, TestStateManager use ??= to respect the body-level TestEnd. Timings are cleared on retry and re-execution. Closes #4711 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
This was referenced Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestEndis now set immediately after the test body finishes (before After hooks run), matchingTestStartwhich is already set after Before hooks completeTimings.Record("BeforeTest"/"AfterTest", ...)for granular visibility in test reportsEndTimeassignments with??=inTestRunner,TestStateManager.MarkCompleted, andTestStateManager.MarkFailedto respect the body-levelTestEndTimingson retry/re-execution inRetryHelperandTestCoordinatoralongside existingTestStart/TestEndresetsCloses #4711
Test plan
🤖 Generated with Claude Code