fix: update Core public API snapshots for all frameworks#4957
fix: update Core public API snapshots for all frameworks#4957
Conversation
Code ReviewIssue found: This PR fixes the snapshot test failures for Why it matters:
// TUnit.Pipeline/Modules/Abstract/TestBaseModule.cs:22
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
yield return "net472";
}Since The Checked against the source files — none of the new code has
Fix: Run the public API tests on |
PR #4956 changed the CancellationTokenMustBeLastParameter diagnostic to point at the CancellationToken parameter instead of the method name. Update 3 test expectations to match the new diagnostic location.
Summary
TUnit.Corebut the snapshot files were not updatedCore_Library_Has_No_API_Changestest failures in all PR CI pipelines (modularpipeline ubuntu/macos/windows jobs)DotNet8_0,DotNet9_0, andDotNet10_0verified snapshot filesTest plan
dotnet test --project TUnit.PublicAPI --framework net8.0passesdotnet test --project TUnit.PublicAPI --framework net9.0passesdotnet test --project TUnit.PublicAPI --framework net10.0passes