Conversation
There was a problem hiding this comment.
Code Review
This is a clean, automated Renovate Bot PR bumping all TUnit self-referencing package versions from 1.17.25 → 1.17.29 across two change surfaces:
Changes Reviewed
Directory.Packages.props— Central Package Management versions for 6 TUnit packages used within the monorepo itself (e.g. comparison/integration test projects).TUnit.Templates/content/— 7 template project files (.csproj/.fsproj/.vbproj) for scaffolded starter projects.
Assessment: ✅ LGTM
All version bumps are consistent and correct across all files. No mismatches between packages in the same logical group. The skip from 1.17.25 to 1.17.29 (batching intermediate patch releases) is expected Renovate behaviour and is safe for patch-level changes.
Minor Observation (Not a Blocker)
The template files use hardcoded version strings, while Directory.Packages.props uses Central Package Management. This is intentional and correct — template content is copied to external projects that are outside the monorepo's CPM scope. Renovate correctly handles both surfaces independently.
One longer-term thing worth considering: the template project files currently need to be updated in 7 separate places. A single MSBuild variable or a nuget.config + Directory.Packages.props pattern in the template root could centralise this, but given Renovate handles it automatically with no issues, this is a very low-priority improvement.
Verdict
Safe to merge. Renovate's automerge is appropriate for this type of patch dependency update.
6a21858 to
2589905
Compare
There was a problem hiding this comment.
Code Review (Follow-up)
Reviewed against the previous comment left on this PR — no changes to the diff since then.
Summary
This is a standard Renovate Bot dependency update bumping all TUnit self-referencing packages from 1.17.25 → 1.17.29 (skipping intermediate patch releases, which is expected batching behaviour).
Files changed:
Directory.Packages.props— 6 TUnit packages updated via Central Package ManagementTUnit.Templates/content/— 7 individual template project files (.csproj/.fsproj/.vbproj) with hardcoded versions
Previous Comment Status
The previous observation about template files needing 7 separate updates (vs. a centralised approach) stands as a low-priority, non-blocking improvement. Since Renovate handles these automatically with no errors, there is no urgency to change this pattern.
Assessment: ✅ LGTM
All version bumps are consistent, correct, and cover every affected surface in the repository. The patch-level nature of this update (1.17.25 → 1.17.29) and Renovate's enabled automerge make this safe to land.
This PR contains the following updates:
1.17.25→1.17.291.17.25→1.17.291.17.25→1.17.291.17.25→1.17.291.17.25→1.17.291.17.25→1.17.291.17.25→1.17.29Release Notes
thomhurst/TUnit (TUnit)
v1.17.29: 1.17.29What's Changed
Other Changes
Dependencies
Full Changelog: v1.17.25...v1.17.29
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.