Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standard-things/esm dependency #138

Closed
7 tasks done
thomvaill opened this issue Nov 24, 2024 · 1 comment
Closed
7 tasks done

Remove standard-things/esm dependency #138

thomvaill opened this issue Nov 24, 2024 · 1 comment
Assignees
Labels
maintenance Maintenance tasks
Milestone

Comments

@thomvaill
Copy link
Owner

thomvaill commented Nov 24, 2024

Blocks #135 (because of standard-things/esm#931)

To be able to remove this dependency, we must first publish compiled JS files that are Node.js "native" compliant, which is not the case today because the import statements don't have .js extensions (among other issues).

  • for each package:
    • either add .js to TypeScript imports or use a bundler like microbundle or tsup

Special case for the web package first needs some refactoring to be able to output compliant code:

  • dissociate the code that wraps Next.js calls of the Next.js codebase itself
    • extract the code shared between the 2 codebases to the core package (or other)
    • separate the two codebases
    • make two distinct build commands
    • reset the Next.js tsconfig.json
@thomvaill
Copy link
Owner Author

Fixed in v1.1.0 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance tasks
Projects
None yet
Development

No branches or pull requests

1 participant