Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apparently, test.cb() has been deprecated by ava #388

Open
JJ opened this issue Oct 18, 2023 · 1 comment
Open

Apparently, test.cb() has been deprecated by ava #388

JJ opened this issue Oct 18, 2023 · 1 comment

Comments

@JJ
Copy link

JJ commented Oct 18, 2023

It's used here

mock-socket/README.md

Line 56 in 47eab99

test.cb('that chat app can be mocked', t => {

Apparently it's been deprecated
@Atrue
Copy link
Collaborator

Atrue commented Oct 19, 2023

Thanks, if you have time you can open a PR with the proper changes

Borewit added a commit to Borewit/mock-socket that referenced this issue Feb 2, 2025
@Borewit
Fix code example
5eff5f5 
Changes:
- Fixes trying to emit a connection when the WebSocket is not yet connected.
- Updated AVA test, resolving thoov#388
@Borewit Borewit mentioned this issue Feb 2, 2025
Open
Borewit added a commit to Borewit/mock-socket that referenced this issue Feb 7, 2025
@Borewit
Fix code example
78adba6 
Changes:
- Fixes trying to emit a connection when the WebSocket is not yet connected.
- Updated AVA test, resolving thoov#388
- Convert incoming messages to `AsyncQueue`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JJ @Atrue