[BUG #212] Send data should be serialized to String

src/helpers/normalize-send.js

@@ -0,0 +1,7 @@
+export default function normalizeSendData(data) {
+  if (Object.prototype.toString.call(data) !== '[object Blob]' && !(data instanceof ArrayBuffer)) {
+    data = String(data);
+  }
+
+  return data;
+}

src/server.js

@@ -5,6 +5,7 @@ import networkBridge from './network-bridge';
 import { CLOSE_CODES } from './constants';
 import globalObject from './helpers/global-object';
 import dedupe from './helpers/dedupe';
+import normalizeSendData from './helpers/normalize-send';
 import { createEvent, createMessageEvent, createCloseEvent } from './event/factory';
 
 /*
@@ -113,6 +114,9 @@ class Server extends EventTarget {
 
     if (typeof options !== 'object' || arguments.length > 3) {
       data = Array.prototype.slice.call(arguments, 1, arguments.length);
+      data = data.map(item => normalizeSendData(item));
+    } else {
+      data = normalizeSendData(data);
     }
 
     websockets.forEach(socket => {

src/websocket.js

@@ -2,6 +2,7 @@ import lengthInUtf8Bytes from './helpers/byte-length';
 import urlVerification from './helpers/url-verification';
 import protocolVerification from './helpers/protocol-verification';
 import delay from './helpers/delay';
+import normalizeSendData from './helpers/normalize-send';
 import EventTarget from './event/target';
 import networkBridge from './network-bridge';
 import { CLOSE_CODES, ERROR_PREFIX } from './constants';
@@ -13,7 +14,7 @@ import { closeWebSocketConnection, failWebSocketConnection } from './algorithms/
 * The main websocket class which is designed to mimick the native WebSocket class as close
 * as possible.
 *
-* https://developer.mozilla.org/en-US/docs/Web/API/WebSocket
+* https://html.spec.whatwg.org/multipage/web-sockets.html
 */
 class WebSocket extends EventTarget {
   constructor(url, protocols) {
@@ -126,20 +127,17 @@ class WebSocket extends EventTarget {
     this.addEventListener('error', listener);
   }
 
-  /*
-  * Transmits data to the server over the WebSocket connection.
-  *
-  * https://developer.mozilla.org/en-US/docs/Web/API/WebSocket#send()
-  */
   send(data) {
     if (this.readyState === WebSocket.CLOSING || this.readyState === WebSocket.CLOSED) {
       throw new Error('WebSocket is already in CLOSING or CLOSED state');
     }
 
+    // TODO: handle bufferedAmount
+
     const messageEvent = createMessageEvent({
       type: 'message',
       origin: this.url,
-      data
+      data: normalizeSendData(data)
     });
 
     const server = networkBridge.serverLookup(this.url);
@@ -151,9 +149,6 @@ class WebSocket extends EventTarget {
     }
   }
 
-  /*
-   * https://html.spec.whatwg.org/multipage/web-sockets.html#dom-websocket-close
-   */
   close(code, reason) {
     if (code !== undefined) {
       if (typeof code !== 'number' || (code !== 1000 && (code < 3000 || code > 4999))) {

tests/unit/server.test.js

@@ -117,3 +117,18 @@ test('that calling close will trigger the onclose of websockets', t => {
   t.is(myServer.originalWebSocket, null, 'server forgets about the original websocket');
   t.deepEqual(globalObj.WebSocket, originalWebSocket, 'the original websocket is returned to the global object');
 });
+
+test.cb('that send will normalize data', t => {
+  const myServer = new Server('ws://not-real/');
+
+  myServer.on('connection', (server, socket) => {
+    myServer.send([1, 2]);
+  });
+
+  const socketFoo = new WebSocket('ws://not-real/');
+  socketFoo.onmessage = message => {
+    t.is(message.data, '1,2', 'data non string, non blob/arraybuffers get toStringed');
+    myServer.close();
+    t.end();
+  };
+});