Substitute CloudFormation Variables for Offline use as well as SSM #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am ok with this change and the "conflict" with the name. Part of me feels as though the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the matching variables for offline use to include those defined for CloudFormation (cf)
As this plugin is called offline-ssm, I'm not 100% sure it should cover CloudFormation too,
it may be best to just create a separate plugin for offline-cf to be included to avoid confusion.
However, for now at least this works for me, and I'd rather just have one plugin to cover the
different sources of variables retrievable from AWS.
The README.md will need to be updated too, but I'll put this out first for discussion on if it's right to include and if any other changes need making before adding changes to the documentation.