Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build on platforms without AtomicU64 #27

Closed
epage opened this issue Mar 6, 2024 · 3 comments · Fixed by #28
Closed

Does not build on platforms without AtomicU64 #27

epage opened this issue Mar 6, 2024 · 3 comments · Fixed by #28

Comments

@epage
Copy link

epage commented Mar 6, 2024

See rust-lang/rust#122054
@epage
Copy link
Author

epage commented Mar 6, 2024

If you want, I can take over maintaining

@epage epage mentioned this issue Mar 6, 2024
Merged
bors added a commit to rust-lang/cargo that referenced this issue Mar 6, 2024
@bors
Auto merge of #13551 - epage:cfg, r=weihanglo
a4c63fe 
fix(cli): Skip tracing-chrome for platforms without 64bit atomics

See rust-lang/rust#122054

I also created thoren-d/tracing-chrome#27
@thoren-d thoren-d mentioned this issue Mar 15, 2024
Merged
thoren-d added a commit that referenced this issue Mar 15, 2024
@thoren-d
Replace use of AtomicU64 with AtomicUsize. (#28)
7e2625a 
This should be sufficient as std requires pointer-sized atomic support.

Fixes #27
@epage
Copy link
Author

epage commented Mar 15, 2024

Thanks!

Could you let us know when a new release is out?

thoren-d added a commit that referenced this issue Mar 15, 2024
@thoren-d
Replace use of AtomicU64 with AtomicUsize. (#28)
5196399 
This should be sufficient as std requires pointer-sized atomic support.

Fixes #27

(cherry picked from commit 7e2625a)
@thoren-d
Copy link
Owner

Working on a release now (as 0.7.2). Should be ready in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace use of AtomicU64 with AtomicUsize. thoren-d/tracing-chrome
2 participants
@epage @thoren-d