Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separate react-native package #13

Closed
4 tasks done
Jyrno42 opened this issue Jul 14, 2017 · 1 comment
Closed
4 tasks done

Remove separate react-native package #13

Jyrno42 opened this issue Jul 14, 2017 · 1 comment
Milestone

Comments

@Jyrno42
Copy link
Contributor

Jyrno42 commented Jul 14, 2017

We created a separate package for react-native as a workaround since there was some collision inside the packager. Since this causes issues with automated deploys, and theres a reference fix available now lets implement it.

More info available at:


  • Remove release script
  • Support for jsnext:main & module fields
  • Reduce babel requirements
  • Test inside react-native (cd into source dir npm link, cd into test-project dir, npm link tg-resources)
Jyrno42 added a commit to Jyrno42/tg-resources that referenced this issue Jul 14, 2017
- Adds separate es build (for webpack 2 and rollup)
- Removes release (related to thorgate#9 and thorgate#13)
Jyrno42 added a commit to Jyrno42/tg-resources that referenced this issue Jul 14, 2017
- Adds separate es build (for webpack 2 and rollup)
- Removes release script (related to thorgate#9 and thorgate#13)
@Jyrno42
Copy link
Contributor Author

Jyrno42 commented Jul 14, 2017

Since we now have esnext build available we can just use that as package.json:react-native value. This ensures we need only as little of babel-runtime as possible (since our build is es2015).

Leaving the issue open until the following is completed:

  • Update README (remove/replace react-native block)
  • Release tg-resources@2.0
  • Deprecate all tg-resources-react-native packages in favour of tg-resources@2.0

@Jyrno42 Jyrno42 modified the milestone: 1.1.0 Jul 14, 2017
@Jyrno42 Jyrno42 closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant