Abortable requests #34
Comments
|
for reference rgs. react-native: facebook/react-native#18115 E: Also, this workaround might be needed: facebook/react-native#18115 (comment) |
- Works & Tested for fetch - TODO: Superagent compatibility and tests Fixes thorgate#34
- Works & Tested for fetch Fixes thorgate#34 TODO: - Superagent compatibility and tests - Check if cross-fetch provides form-data or not
|
Got it working with Had to swap out |
Works & Tested for fetch and superagent, both using the same external API. - Replaces isomorphic-fetch with cross-fetch since the latter is maintained. Sadly no form-data in cross-fetch so we still need to keep form-data things in our dependencies. Fixes thorgate#34
Works & Tested for fetch and superagent, both using the same external API. - Replaces isomorphic-fetch with cross-fetch since the latter is maintained. Sadly no form-data in cross-fetch so we still need to keep form-data things in our dependencies. See thorgate#34
Works & Tested for fetch and superagent, both using the same external API. - Replaces isomorphic-fetch with cross-fetch since the latter is maintained. Sadly no form-data in cross-fetch so we still need to keep form-data things in our dependencies. See thorgate#34
|
Superagent now also works |
Works & Tested for fetch and superagent, both using the same external API. - Replaces isomorphic-fetch with cross-fetch since the latter is maintained. Sadly no form-data in cross-fetch so we still need to keep form-data things in our dependencies. See thorgate#34
Works & Tested for fetch and superagent, both using the same external API. - Replaces isomorphic-fetch with cross-fetch since the latter is maintained. Sadly no form-data in cross-fetch so we still need to keep form-data things in our dependencies. See thorgate#34
|
Sad news about react-native, currently I did not manage to get aborting to work. See my testing repo here: https://github.com/Jyrno42/rn-tg-resources-tester. The following commit contains a testcase for aborting a request on react native and some explanations on what I tried to get aborting to work |
|
We should do a release without RN support. We should also try to advocate (or do it ourselves) the AbortController thing inside rn core. |
|
Released in v3.1.0 |
|
Some progress on react-native support - got it working with After that I would focus my efforts towards getting facebook/react-native#18115 resolved. Seemed to get it working by updating whatwg-fetch inside react-native core manually and using |
I think adding support for
Aborting requestsrequires some more planning due to the differences betweenfetchandsuperagentin how they deal with aborting requests.In fetch one needs to provide an AbortController.signal in the arguments to the
fetchcall. The controller itself has a methodabortwhich can be called to cancel the request. When a request is cancelled it's promise is rejected.However, with superagent -
abortis a method on the request. Upon abortthe promises behaves similarly to fetch.It actually doesn't, we need to add a listener toabortevent and reject via that.Based on this, I have a couple of questions that need to get answered before we agree upon the final API for abortable requests.
saga-resource?Progress
The text was updated successfully, but these errors were encountered: