fix: added missing check on enabled online update

thorsten · Nov 30, 2024 · 34d5c4d · 34d5c4d
1 parent 26669ed
commit 34d5c4d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/phpmyfaq/admin/header.php b/phpmyfaq/admin/header.php
@@ -160,7 +160,9 @@
     'ad_menu_stopwordsconfig',
     $action
 );
-$secLevelEntries['config'] .= $adminHelper->addMenuEntry('editconfig', 'upgrade', 'ad_menu_upgrade', $action);
+if ($faqConfig->get('upgrade.onlineUpdateEnabled')) {
+    $secLevelEntries['config'] .= $adminHelper->addMenuEntry('editconfig', 'upgrade', 'ad_menu_upgrade', $action);
+}
 if ($faqConfig->get('search.enableElasticsearch')) {
     $secLevelEntries['config'] .= $adminHelper->addMenuEntry(
         'editconfig',

diff --git a/phpmyfaq/admin/upgrade.php b/phpmyfaq/admin/upgrade.php
@@ -35,7 +35,10 @@
 $twig = new TwigWrapper(PMF_ROOT_DIR . '/assets/templates');
 $template = $twig->loadTemplate('./admin/configuration/upgrade.twig');
 
-if ($user->perm->hasPermission($user->getUserId(), PermissionType::CONFIGURATION_EDIT->value)) {
+if (
+    $faqConfig->get('upgrade.onlineUpdateEnabled') &&
+    $user->perm->hasPermission($user->getUserId(), PermissionType::CONFIGURATION_EDIT->value)
+) {
     $templateVars = [
         'adminHeaderUpgrade' => Translation::get('ad_menu_upgrade'),
         'headerCheckHealth' => Translation::get('headerCheckHealth'),