Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-quantum-gates.Rmd #51

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

diffeo-christopher
Copy link
Contributor

Add minus sign to the equation for p and add Hamiltonian mechanics link from Wikipedia

Add minus sign and Hamiltonian link
@thosgood thosgood added the correction Simple typos or more detailed corrections label Dec 10, 2024
@thosgood
Copy link
Owner

thanks! would you like me to leave this pull request open for a little while so you can make any other fixes here?

@diffeo-christopher
Copy link
Contributor Author

Yes, that makes sense! I'll @ you when I'm ready for a review.

@thosgood thosgood marked this pull request as draft December 10, 2024 23:37
@diffeo-christopher
Copy link
Contributor Author

Note: the sidenotes are overlapping on this page since paragraphs aren't long enough to keep them separate:
https://github.com/thosgood/qubit.guide/pull/51/files#diff-eec7d39a492b412ac220cf9903850095899c6a355ca7895c8d399b71255c9783R954-R959

If the window is narrow enough, they look fine since they become
Screenshot 2024-12-14 at 14 24 03

@diffeo-christopher
Copy link
Contributor Author

@thosgood I think it makes sense to submit this PR now so that it doesn't get too long? Most of the commits are suggestions about typos, and I can do another PR for Sections 8-15? If you'd rather them all be in one PR please feel free to change this back into a draft!

@diffeo-christopher diffeo-christopher marked this pull request as ready for review December 21, 2024 21:43
@diffeo-christopher
Copy link
Contributor Author

@thosgood One other general commit: the stabilizer chapter is by necessity more heavy on group theory, and in that chapter quotient groups are defined. However, they'd been mentioned and used throughout the preceding text, and it made me wonder if maybe there should be a group theory section in the mathematical preliminaries chapter. Just a thought!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Simple typos or more detailed corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants