Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more fields when filtering in contributors query #272

Closed
ja573 opened this issue Aug 10, 2021 · 2 comments · Fixed by #278
Closed

Use more fields when filtering in contributors query #272

ja573 opened this issue Aug 10, 2021 · 2 comments · Fixed by #278
Assignees
Labels
enhancement Improvement request

Comments

@ja573
Copy link
Member

ja573 commented Aug 10, 2021

At present search is done in fullName and orcid. We should include lastName, too. A use case is searching a contributor without their middle name doesn't return the expected contributor, e.g. filtering with "Martin Eve" doesn't return "Martin Paul Eve"s record.

@ja573 ja573 added the enhancement Improvement request label Aug 10, 2021
@rhigman
Copy link
Member

rhigman commented Aug 27, 2021

Filtering on lastName alone wouldn't solve the problem stated in the use case (as searching for "Martin Eve" in the lastName field wouldn't return "Eve"). We would also need to split the filter string on spaces, and search for each substring separately. For the use case given, searching in fullName would then return the desired result, without needing to include lastName.

@rhigman
Copy link
Member

rhigman commented Aug 31, 2021

I attempted splitting the filter string on spaces in d28fef6, but the results returned were poor, as the number of hits potentially increased every time a new word/name was added to the filter string - making it harder to see actual matches.

rhigman added a commit that referenced this issue Sep 2, 2021
…m_delete

Minor fixes: confirm publication delete (#266), subjectCount filter default (#271), filter contributors on lastName (#272)
@rhigman rhigman closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement request
Projects
None yet
2 participants