Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSTOR-compliant ONIX 3.0 XML output #283

Merged
merged 8 commits into from
Oct 1, 2021

Conversation

rhigman
Copy link
Member

@rhigman rhigman commented Sep 9, 2021

Fixes #44 by creating a new, separate ONIX output, based on the Project MUSE output, which fixes the minor issues noted in #44 (comment).

We are still awaiting feedback from a) JSTOR, to confirm that the changed format does now meet their requirements, and b) Project MUSE, to comment on whether the changed format would be acceptable to them.

If Project MUSE have no issues with the minor changes, we should ideally merge the separate MUSE and JSTOR outputs back into a single "flavour". This PR allows users to create JSTOR-compliant output in the meantime.

@rhigman rhigman requested a review from ja573 September 9, 2021 12:26
@rhigman rhigman linked an issue Sep 9, 2021 that may be closed by this pull request
@ja573
Copy link
Member

ja573 commented Oct 1, 2021

I guess that even if MUSE accepts this specification we should keep them separate, but link them under platform, e.g. onix_3.0::jstor -- accepted_by--->["/platforms/jstor", "/platforms/project_muse"]

@rhigman rhigman merged commit f5c10e5 into develop Oct 1, 2021
@rhigman rhigman deleted the feature/44_jstor_output branch October 1, 2021 09:58
@rhigman
Copy link
Member Author

rhigman commented Oct 1, 2021

I guess that even if MUSE accepts this specification we should keep them separate, but link them under platform, e.g. onix_3.0::jstor -- accepted_by--->["/platforms/jstor", "/platforms/project_muse"]

Good point. Since MUSE said they could only accept titles with at least one BIC/BISAC and didn't want Keywords included, I'm about to make that change to the MUSE specification, which would make it diverge from the JSTOR specification anyway.

@rhigman
Copy link
Member Author

rhigman commented Oct 7, 2021

JSTOR have now confirmed that this format meets their specifications.

As mentioned above, MUSE have stricter requirements for subject codes, so would not be able to ingest this format. However, they didn't mention any objections to the changes JSTOR initially requested (listed under #44 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output to JSTOR
2 participants