Implement ONIX 2.1 output compliant with EBSCO Host requirements (#49, #43) #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect indenting for ease of diffing/retain valid optional fields omitted from example)
ja573
requested changes
Oct 1, 2021
There was a problem hiding this comment.
It'll make sense to differentiate the various EBSCO arms in the specifications, too (not just in platforms). Could you rename all instances of "ebsco" with "ebsco_host"? e.g. "onix_2.1::ebsco_host". Not just in data.rs but throughout the export API, e.g. methods, file names, etc.
…tinguish from EBSCO KB
…eature/49_ebsco_onix2.1
ja573
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43 and part-fixes #49 (EBSCO Host require ONIX 2.1, EBSCO KnowledgeBase require KBART - and are provisionally happy with the format created under #277).