Update Project MUSE ONIX subject output logic #299
Conversation
…code; don't include keywords
… MUSE output for consistency/compatibility
| write_element_block("SubjectCode", w, |w| { | ||
| w.write(XmlEvent::Characters(&subject.subject_code)) | ||
| // Project MUSE can't process records containing keywords | ||
| if subject.subject_type != SubjectType::KEYWORD { |
There was a problem hiding this comment.
Should we also ignore SubjectType::CUSTOM?
There was a problem hiding this comment.
Project MUSE explictly confirmed that "outputting "custom" subject codes with SubjectSchemeIdentifier B2 is acceptable and will not cause us any problems".
The broader question (which I think came up in passing at our recent meeting) is whether we should be outputting SubjectType::CUSTOM for any of the flavours, since they're (for OBP at least) internal-only and therefore irrelevant to distributors (and possibly not ingested by them). At the moment, we output it for all flavours except OAPEN.
There was a problem hiding this comment.
In that case let's leave them. I guess there's no harm in outputting them if they're going to be ignored
In a meeting between members of Thoth and Project MUSE on 2021-09-29 (minutes), MUSE mentioned that they require at least one BIC or BISAC subject code in each ONIX record, and cannot process records containing "keyword" subject codes. They reported no problems with the minor changes requested by JSTOR, suggesting that these are acceptable to merge back in to the MUSE ONIX output.
This PR makes these changes, and marks that MUSE output is also acceptable to JSTOR, and OAPEN output is also acceptable to DOAB.