Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/426 update ebsco host price #427

Merged
merged 15 commits into from
Sep 20, 2022
Merged

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Sep 20, 2022

Fixes #426 and #420

@ja573 ja573 requested a review from rhigman September 20, 2022 08:52
Copy link
Member

@rhigman rhigman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As it happens, ProQuest Ebrary recently confirmed that they would be able to accept our ONIX 2.1 files if the price were 0.00 rather than 0.01, so that's convenient! Could you also add them to the list of supported platforms, and update the price point comment as suggested?

thoth-export-server/src/xml/onix21_ebsco_host.rs Outdated Show resolved Hide resolved
rhigman
rhigman previously approved these changes Sep 20, 2022
@ja573 ja573 merged commit 65cf778 into develop Sep 20, 2022
@ja573 ja573 deleted the feature/426_update_ebsco_host_price branch September 20, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants