Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #425 #428

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Fix #425 #428

merged 2 commits into from
Sep 20, 2022

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Sep 20, 2022

Closes #425

@ja573 ja573 requested a review from rhigman September 20, 2022 10:08
rhigman
rhigman requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@rhigman rhigman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to be changed in the client (schema.json) and export server?

@ja573 ja573 requested a review from rhigman September 20, 2022 12:15
@ja573
Copy link
Member Author

ja573 commented Sep 20, 2022

Does this also need to be changed in the client (schema.json) and export server?

Yes, it does. I should have grepped with the case insensitive flag...

@ja573 ja573 merged commit c5f6249 into develop Sep 20, 2022
@ja573 ja573 deleted the feature/425_illustrator_typo branch September 20, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhigman rhigman rhigman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ja573 @rhigman