Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend csv_thoth output to include recent data model enhancements (references, etc) #455

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

rhigman
Copy link
Member

@rhigman rhigman commented Nov 9, 2022

No description provided.

@rhigman rhigman requested a review from ja573 November 9, 2022 11:25
Copy link
Member

@ja573 ja573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of outputting the ordinal number (in e.g. subjects) it'd be better to use the ordinal to output them in the right order

@rhigman
Copy link
Member Author

rhigman commented Nov 15, 2022

Instead of outputting the ordinal number (in e.g. subjects) it'd be better to use the ordinal to output them in the right order

I've realised subjects were already being output in order:

subjects.sort_by(|a, b| a.subject_ordinal.cmp(&b.subject_ordinal));

Following 3e8bae0, so should everything else that has ordinals (the quoted line becomes redundant). So the remaining desired change will be to take the ordinals back out again - yes?

@ja573
Copy link
Member

ja573 commented Nov 16, 2022

Instead of outputting the ordinal number (in e.g. subjects) it'd be better to use the ordinal to output them in the right order

I've realised subjects were already being output in order:

subjects.sort_by(|a, b| a.subject_ordinal.cmp(&b.subject_ordinal));

Following 3e8bae0, so should everything else that has ordinals (the quoted line becomes redundant). So the remaining desired change will be to take the ordinals back out again - yes?

Yes, exactly

@rhigman rhigman requested a review from ja573 November 16, 2022 11:00
@rhigman rhigman merged commit 907f548 into develop Nov 16, 2022
@rhigman rhigman deleted the feature/extend_csv_thoth branch November 16, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants