Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to check that changelog has been updated #557

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Feb 13, 2024

No description provided.

@ja573 ja573 requested a review from rhigman February 13, 2024 16:39
@rhigman
Copy link
Member

rhigman commented Feb 14, 2024

Note that the third-party action used hasn't yet been updated to account for the Node v20 requirement, so we're getting warning annotations on runs e.g. https://github.com/thoth-pub/thoth/actions/runs/7889770920. Perhaps raise this as an issue with the maintainer.

@ja573
Copy link
Member Author

ja573 commented Feb 14, 2024

Note that the third-party action used hasn't yet been updated to account for the Node v20 requirement, so we're getting warning annotations on runs e.g. https://github.com/thoth-pub/thoth/actions/runs/7889770920. Perhaps raise this as an issue with the maintainer.

Good point! I had assumed they didn't use node as it's just a bash script, but it's the underlying actions/checkout action that relies in node v16

@ja573 ja573 merged commit f10a5c2 into develop Feb 14, 2024
8 checks passed
@ja573 ja573 deleted the feature/check_changelog_action branch February 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants