Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/568 build wasm from cargo #569

Merged
merged 38 commits into from
Feb 29, 2024
Merged

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Feb 26, 2024

  • Removes the need to run wasm-pack before cargo build, i.e. cargo build can build the wasm target by making it a requirement of thoth-app-server through the custom build script thoth-app-server/build.rs
  • Replaces wasm-pack and rollup with trunk, wich has its build configuration defined in thoth-app/Trunk.toml. By not bundling the app with rollup we can also get rid of node/npm as build dependencies
  • Optionally load env variables from .env before building thoth-app and thoth-export-server, to eliminate the need to manually load env vars before running cargo build, cargo test, etc.

@ja573 ja573 merged commit cec4dff into develop Feb 29, 2024
14 checks passed
@ja573 ja573 deleted the feature/568_build_wasm_from_cargo branch February 29, 2024 07:54
@ja573 ja573 linked an issue Feb 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wasm from cargo
2 participants