Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions #626

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Add descriptions #626

merged 10 commits into from
Sep 6, 2024

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Sep 5, 2024

No description provided.

@brendan-oconnell brendan-oconnell self-assigned this Sep 5, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@brendan-oconnell brendan-oconnell marked this pull request as ready for review September 5, 2024 14:30
@brendan-oconnell
Copy link
Contributor

@ja573 I can't request you as a reviewer on your own PR, but I'd appreciate you reviewing my sections, especially my db migrations - thanks!

thoth-api/src/model/work/mod.rs Outdated Show resolved Hide resolved
@@ -75,7 +75,9 @@ pub enum WorkType {
#[cfg_attr(
feature = "backend",
derive(DbEnum, juniper::GraphQLEnum),
graphql(description = "Publication status of a work"),
graphql(
description = "Publication status of a work throughout its lifecycle. For a visual representation of the workflow, refer to the work status flowchart https://github.com/thoth-pub/thoth/wiki/Thoth_Works#work-status-flowchart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, one of the boxes in this flowchart isn't displaying properly for me in Firefox (although it's working in Chromium, weirdly)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which box is it? They display fine for me in firefox and safari

Copy link
Member

@rhigman rhigman Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSTPONED_INDEFINITELY (on v130.0 64-bit):

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd – does it display properly in the original #595 (comment) ? It should be exactly the same mermaid code

Copy link
Member

@rhigman rhigman Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, yes, I'm getting the same display problem there, but I definitely didn't notice it when originally reading that discussion! Could be to do with updates I've installed in the meantime...

@ja573 ja573 merged commit 7fa6ae7 into develop Sep 6, 2024
13 checks passed
@ja573 ja573 deleted the feature/add_work_status_descriptions branch September 6, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants