Better handling of missing DOIs when outputting Crossref metadata (#551, #565) #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 9, 2024
ja573
reviewed
Sep 9, 2024
| @@ -79,14 +79,25 @@ impl XmlSpecification for DoiDepositCrossref { | |||
|
|
|||
| impl XmlElementBlock<DoiDepositCrossref> for Work { | |||
| fn xml_element<W: Write>(&self, w: &mut EventWriter<W>) -> ThothResult<()> { | |||
| let work_type = match &self.work_type { | |||
| let work = self; | |||
There was a problem hiding this comment.
I know this was introduced earlier, but I don't think it's necessary to declare this variable
| "Missing chapter DOI".to_string(), | ||
| )); | ||
| // Caller should only pass in chapters which have DOIs | ||
| unreachable!() |
There was a problem hiding this comment.
I guess we can now get rid off this condition and simply unwrap the DOI
let doi = chapter
.related_work
.doi
.as_ref()
.expect("Caller should only pass in chapters which have DOIs");
```
ja573
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551 and #565. Solution implemented for #551 was to exclude chapters without DOIs from existing Crossref output, rather than making a new output (as discussed in issue comments).