Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment once fixed https://github.com/thoth-station/adviser/issues/1541 #1549

Closed
todo bot opened this issue Nov 5, 2020 · 4 comments
Closed
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. todo 🗒️

Comments

@todo
Copy link

todo bot commented Nov 5, 2020

adviser/tests/test_beam.py

Lines 250 to 255 in 275fc72

# TODO: uncomment once fixed https://github.com/thoth-station/adviser/issues/1541
# with pytest.raises(ValueError):
# beam.remove(state1)
assert beam.max() is state3


This issue was generated by todo based on a TODO comment in 275fc72 when #1548 was merged. cc @thoth-station.
@todo todo bot added the todo 🗒️ label Nov 5, 2020
@fridex
Copy link
Contributor

fridex commented Nov 5, 2020

Related to #1541

@sesheta
Copy link
Member

sesheta commented Apr 17, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2021
@fridex
Copy link
Contributor

fridex commented Apr 19, 2021

Closing with respect to #1541

/close

@sesheta
Copy link
Member

sesheta commented Apr 19, 2021

@fridex: Closing this issue.

In response to this:

Closing with respect to #1541

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. todo 🗒️
Projects
None yet
Development

No branches or pull requests

2 participants