Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring some coala errors #418

Merged
merged 1 commit into from
Dec 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion thoth/storages/ceph.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def __init__(
def get_document_listing(self) -> typing.Generator[str, None, None]:
"""Get listing of documents stored on the Ceph."""
for obj in self._s3.Bucket(self.bucket).objects.filter(Prefix=self.prefix).all():
yield obj.key[len(self.prefix) :]
yield obj.key[len(self.prefix) :] # Ignore PycodestyleBear (E203)

@staticmethod
def dict2blob(dictionary: dict) -> bytes:
Expand Down
10 changes: 5 additions & 5 deletions thoth/storages/graph/janusgraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def _get_hashable_id(val):
return result


def requires_connection(func):
def requires_connection(func): # Ignore PyDocStyleBear
"""Force implicit connection if not connected already."""

@functools.wraps(func)
Expand Down Expand Up @@ -831,7 +831,7 @@ def _get_hardware_information(self, specs: dict) -> HardwareInformation:
ram_size=self._parse_memory(specs["memory"]) if specs.get("memory") else None,
)

def create_software_stack_pipfile(self, pipfile_locked: dict) -> SoftwareStack:
def create_software_stack_pipfile(self, pipfile_locked: dict) -> SoftwareStack: # Ignore PyDocStyleBear
"""Create a software stack inside graph database from a Pipfile.lock."""

def get_index_url(index_name: str):
Expand All @@ -852,7 +852,7 @@ def get_index_url(index_name: str):
)
package_version = package_info["version"]
else:
package_version = package_info["version"][len("==") :]
package_version = package_info["version"][len("==") :] # Ignore PycodestyleBear (E203)

index_url = get_index_url(package_info["index"])

Expand Down Expand Up @@ -1069,7 +1069,7 @@ def sync_solver_result(self, document: dict) -> None:
for index_entry in dependency["resolved_versions"]:
index_url = index_entry["index"]
for dependency_version in index_entry["versions"]:
python_package_dependency, _, python_package_version_dependency = self.create_pypi_package_version(
python_package_dependency, _, python_package_version_dependency = self.create_pypi_package_version( # Ignore PycodestyleBear (E501)
package_name=dependency["package_name"],
package_version=dependency_version,
index_url=index_url,
Expand Down Expand Up @@ -1128,7 +1128,7 @@ def sync_solver_result(self, document: dict) -> None:
)
continue

package_version = unsolvable["version_spec"][len("==") :]
package_version = unsolvable["version_spec"][len("==") :] # Ignore PycodestyleBear (E203)
try:
python_package, _, python_package_version = self.create_pypi_package_version(
package_name=unsolvable["package_name"],
Expand Down
4 changes: 2 additions & 2 deletions thoth/storages/graph/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
_LOGGER = logging.getLogger(__name__)


def enable_vertex_cache(func: typing.Callable):
def enable_vertex_cache(func: typing.Callable): # Ignore PyDocStyleBear
"""Enable vertex caching."""

@wraps(func)
Expand All @@ -60,7 +60,7 @@ def wrapped(*args, **kwargs):
return wrapped


def enable_edge_cache(func: typing.Callable):
def enable_edge_cache(func: typing.Callable): # Ignore PyDocStyleBear
"""Enable caching for edge handling."""

@wraps(func)
Expand Down