-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Venture Adventure's debugging output to check for state changes #193
Update Venture Adventure's debugging output to check for state changes #193
Conversation
…hub.com/MHLoppy/arcade-games into doc/venture-adventure-smarter-debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Works a lot better to actually be able to stop and read the output!
And definitely nice to still be able to toggle it with once change.
I do think a lot of the output there is useful for debugging based on what I've worked on, but there's certainly room for improvement and/or making it easier to customize depending on what someone's working on.
We can ignore the error about the missing 'back' file, as I've resolved that in another PR. Looks like the libpng/sRGB warning is here too, not sure if that's a local thing to me or not but doesn't seem to cause any issues.
Looks good still after conflicts resolved |
@MHLoppy I've just updated the PingPong config.txt file to try to resolve the workflow failing. Try pulling that change into your fork/branch and commit that change, then you can message me on Teams to let me know and I can re-run the jobs. :) |
Description
The current console debugging dumps a bunch of info every single cycle, which floods the console with mostly low-value information. Whilst whether the current debugging infodump is actually useful or not can be debated, in the meantime we can at least increase the signal-to-noise-ratio of the output by tracking the game state and comparing the current cycle's state vs the previous cycle's state.
If no change has been made, the infodump is not sent and a "waiting for changes..." message is sent once. Once the (tracked) state changes again, the updated infodump is sent.
Castiel mentioned how it was nice to be able to turn the debugging on/off by changing one line of code, so I've maintained this feature using a bool check before running the new code (change the bool to turn off the debugging output).
Type of change
How Has This Been Tested?
I built and ran Venture Adventure with the updated code and monitored the console output.
Testing Checklist
N/A
Checklist
have requestedwill request a review from the team on Teams etc* I'm working on some documentation updates elsewhere, so will include a note about flipping the bool in that documentation.