Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venture Adventure - Small refactor (part 2) #221

Closed

Conversation

MHLoppy
Copy link
Contributor

@MHLoppy MHLoppy commented Aug 4, 2024

Description

While getting working on Venture Adventure again, I felt like there was low-hanging fruit available to refactor that would make future work easier. I've split this work into several parts of related changes to make for smaller PRs that are easier to review.

This is part 2/5 (building on the previous changes made in the chain) and is focused on improving the way levels are tracked to require less variables.

Type of change

  • Other: refactor

How Has This Been Tested?

I recompiled the game and played through it, ensuring that all refactored functionality threw no errors and worked the same as pre-refactor.

Testing Checklist

  • Played through all of level 1
  • Played through all of level 2
  • Played start of level 1 after cycling through main menu after completing both level 1 + level 2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I'll notify my team when the PR is ready to review

@github-actions github-actions bot added the compiled the source code has been successfully compiled label Aug 4, 2024
@MHLoppy
Copy link
Contributor Author

MHLoppy commented Aug 24, 2024

Superceded by #228 after merge conflicts

@AmberPotion
Copy link
Contributor

Cool

@AmberPotion AmberPotion closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiled the source code has been successfully compiled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants