Skip to content

Conversation

@Duy-Nguyen1104
Copy link

@Duy-Nguyen1104 Duy-Nguyen1104 commented May 15, 2025

Description

This pull request introduces the Requirement feature to the CourseFlow API, as I noticed that a requirement entity is not created based on this doc requirement: https://thoth-tech.netlify.app/products/courseflow/documentation/design/backend-functional-requirements/#requirements.
It adds a new Requirement model, migration, and API routes for creating, retrieving, updating, and deleting requirements.
Relevant tests have also been created or updated to ensure the correctness of the new endpoints and model logic.

Type of change

  • [x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [ x] Added and ran unit tests for the new Requirement model and API endpoints.
  • [ x] Checked that all existing and new tests pass locally
  • [xx ] Verified API routes using automated request specs and manual testing via Postman
  • [ x] Confirmed database migration applies cleanly and schema is updated.

image

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works

Copy link

@giangnht19 giangnht19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on migrating new requirement entity in the backend. I was able to pull and test this feature.
image

@agamv25
Copy link

agamv25 commented May 16, 2025

I ran the code on my machine and tested the code, everything seems to run correctly and according to the documentation.

@aNebula
Copy link

aNebula commented Jun 12, 2025

LGTM.
@Duy-Nguyen1104 please open an upstream PR against new/course-flow branch in doubtfire-lms/doubtfire-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants