Skip to content

Conversation

@MillicentAmolo
Copy link

Description
This update enhances the authentication API by refining the logic in authentication_api.rb to ensure more reliable and secure handling of authentication requests. In addition, the Gemfile.lock has been updated to align with the latest dependency versions, ensuring compatibility and stability across the application.

Fixes # (issue)
update authentication API and dependencies

Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Ran local server and confirmed login/authentication flow works as expected.

Verified dependencies install and run without errors.

Test A Authentication API request/response validation.

Test B Dependency installation and application startup

Checklist:
[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if appropriate
[ x] My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have created or extended unit tests to address my new additions
[x ] New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
If you have any questions, please contact @macite or @jakerenzella.

@AB-Deakin
Copy link

78branch
Merging branch needs to be updated to 9.x not development

@MillicentAmolo MillicentAmolo changed the base branch from development to 9.x September 18, 2025 13:09
Copy link

@AB-Deakin AB-Deakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ran tests on the API changes to password management and it is working correctly. However the feature/password-management-api branched off the development branch not 9.x when all the changes were made this will lead to merge conflicts and sync issues like having to update the gemlock file dependencies that were out of date on the development branch. Will need to be rebuilt as a branch off of 9.x
test1
test2

Copy link

@ibi420 ibi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MillicentAmolo , great work on this. I can confirm the functionality works as expected. Despite the earlier issue with creating the function on the development branch instead of 9.x, everything now runs smoothly without errors. You added documentation to the backend. all documentation should be opened to doubtfire-astro. Please remove the docs/password_management_security.md and add it to your documentation pr. The backend is strictly for backend code. I also do not understand why you have modified the .vscode/settings.json and .gitignore files. Please explain this.

@ibi420
Copy link

ibi420 commented Sep 19, 2025

I just looked through the commit history and noticed the changes to the files .vscode/settings.json and .gitignore were from Andrew. I am not sure how you went about opening this PR but we can look past that. Please move the documentation on this to the astro branch.

@MillicentAmolo
Copy link
Author

Hello Ibi,
I have deleted the documentation from the API and moved it astro and pushed it.

@MillicentAmolo
Copy link
Author

Hey @MillicentAmolo , great work on this. I can confirm the functionality works as expected. Despite the earlier issue with creating the function on the development branch instead of 9.x, everything now runs smoothly without errors. You added documentation to the backend. all documentation should be opened to doubtfire-astro. Please remove the docs/password_management_security.md and add it to your documentation pr. The backend is strictly for backend code. I also do not understand why you have modified the .vscode/settings.json and .gitignore files. Please explain this.
Hey @ibi420
.vscode/settings.json
This ensures that all files use Unix-style line endings (LF - \n) instead of Windows-style line endings (CRLF - \r\n) and it is important for cross-platform development to maintain consistency in line endings across different operating systems and prevent issues with version control
.gitignore
Before I thought that doubt-astro was separate from the project but after your feedback is when I realized that it’s part of the project and I have removed doubtfire-astro/ from .gitignore. then committed and pushed to main.

Have also committed and pushed the deleted documentation from the backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants