-
Notifications
You must be signed in to change notification settings - Fork 121
Implement password management API updates #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
Implement password management API updates #78
Conversation
AB-Deakin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've ran tests on the API changes to password management and it is working correctly. However the feature/password-management-api branched off the development branch not 9.x when all the changes were made this will lead to merge conflicts and sync issues like having to update the gemlock file dependencies that were out of date on the development branch. Will need to be rebuilt as a branch off of 9.x


ibi420
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MillicentAmolo , great work on this. I can confirm the functionality works as expected. Despite the earlier issue with creating the function on the development branch instead of 9.x, everything now runs smoothly without errors. You added documentation to the backend. all documentation should be opened to doubtfire-astro. Please remove the docs/password_management_security.md and add it to your documentation pr. The backend is strictly for backend code. I also do not understand why you have modified the .vscode/settings.json and .gitignore files. Please explain this.
|
I just looked through the commit history and noticed the changes to the files |
|
Hello Ibi, |
Have also committed and pushed the deleted documentation from the backend |

Description
This update enhances the authentication API by refining the logic in authentication_api.rb to ensure more reliable and secure handling of authentication requests. In addition, the Gemfile.lock has been updated to align with the latest dependency versions, ensuring compatibility and stability across the application.
Fixes # (issue)
update authentication API and dependencies
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Ran local server and confirmed login/authentication flow works as expected.
Verified dependencies install and run without errors.
Test A Authentication API request/response validation.
Test B Dependency installation and application startup
Checklist:
[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if appropriate
[ x] My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have created or extended unit tests to address my new additions
[x ] New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
If you have any questions, please contact @macite or @jakerenzella.