-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure danger buttons have red hover state (#2742)
074cb1a converted links that submit forms to buttons. To keep these now-buttons looking like links it uses the `link` class. CSS looks for buttons that are `not(.link)` to continue to style them appropriately. However any `.button--danger` buttons did not get all the style overrides. In particular, `:hover` and `:disabled:hover` states fell back to the normal button background colors (blue). This fixes those buttons to have the appropriate red hover states. In addition, `.link--danger` elements also had a blue hover state. I'm not sure when this was broken, or if it was always supposed to be like that. Either way, I changed it so they now also appear slightly darker when hovered to match the buttons.
- Loading branch information
1 parent
52218fc
commit 808cdfa
Showing
4 changed files
with
32 additions
and
15 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters