-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
administrate:views:layout task doesn't generate stylesheet partial #888
Comments
apraditya
changed the title
administrate:views:layout task doesn't generate stylesheet partial
May 14, 2017
administrate:views:layout
task doesn't generate stylesheet
partial
Additionally, the generator doesn't generate the search or icons partials. Is this intended behavior? |
nickcharlton
added a commit
that referenced
this issue
Jun 23, 2017
This produces a file like the following: <%# # Stylesheet Partial This partial imports the necessary stylesheets on each page. By default, it includes the application CSS, but each page can define additional CSS sources by providing a `content_for(:stylesheet)` block. %> <% Administrate::Engine.stylesheets.each do |css_path| %> <%= stylesheet_link_tag css_path %> <% end %> <%= yield :stylesheet %> In `app/views/admin/application/_stylesheet.html.erb`. Fixes #888.
Nice catch! I've opened #916 to add this in. |
@professorNim It sounds like we're missing generators for it. Could you open an issue (or better) a PR? |
@nickcharlton I'm confused, didn't you do just that with #916? |
nickcharlton
added a commit
that referenced
this issue
Jul 3, 2017
This produces a file like the following: <%# # Stylesheet Partial This partial imports the necessary stylesheets on each page. By default, it includes the application CSS, but each page can define additional CSS sources by providing a `content_for(:stylesheet)` block. %> <% Administrate::Engine.stylesheets.each do |css_path| %> <%= stylesheet_link_tag css_path %> <% end %> <%= yield :stylesheet %> In `app/views/admin/application/_stylesheet.html.erb`. Fixes #888.
mashedkeyboard
added a commit
to mashedkeyboard/administrate
that referenced
this issue
Jan 29, 2019
In thoughtbot#888, it was noted that the stylesheet and icons partials weren't generated by the Rails generator command; stylesheet was fixed, but icons never seemed to be. This addresses that issue.
nickcharlton
pushed a commit
that referenced
this issue
Aug 16, 2019
In #888, it was noted that the stylesheet and icons partials weren't generated by the Rails generator command; stylesheet was fixed, but icons never seemed to be. This addresses that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using 0.7.0. The
administrate:views:layout
task doesn't generateapp/views/admin/application/_stylesheet.html.erb
file.The text was updated successfully, but these errors were encountered: