number_field for Field::Number #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codergeek121
changed the title
|
Hi @codergeek121! I'm not sure a test would be 100% valuable in this scenario. Is there some validation/presentation that Could you also rebase against master? I wonder if that'll now help with that first commit. |
|
Hi @nickcharlton! I was just working with the gem and wondering why |
|
@jdrosales17 - If you rebase this (skipping the first commit, now unnecessary) and create a new PR, I'll be happy to review it. |
nickcharlton
added
feature
|
I think we're good here. Maybe there will be a regression and we can pick that up but the combination of using the right field type and "any" is good for now. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the partial for the Field::Number to use the number_field view helper instead of the text_field helper. The tests failed for my cloned master branch, but my first commit fixes it.
Is a new test for the input_field change necessary, and if so what would be a good test to write?
This PR is for Issue #1021.
Happy to help.