Add Ruby 2.2.9 to Circle and clarify support. #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
force-pushed
the
nc-ruby-support
branch
2 times, most recently
from
e8b6864 to
4e51e2b
Compare
pablobm
reviewed
Jan 26, 2018
nickcharlton
force-pushed
the
nc-ruby-support
branch
from
4e51e2b to
1860181
Compare
|
That's my thinking. The problem I foresee is that the combination of Ruby EOL, Rails versions and people's actual deployments never really line up perfectly …but also neither will we in keeping track here. |
The version support is informed by: * https://stackoverflow.com/a/23532476/83386 * http://guides.rubyonrails.org/5_0_release_notes.html Closes #1010.
This can be reverted once we drop support.
nickcharlton
force-pushed
the
nc-ruby-support
branch
from
c5da104 to
6bfc705
Compare
geoffharcourt
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version support is informed by:
Closes #1010.