Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include_blank in Belongs to form #1222

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Include_blank in Belongs to form #1222

merged 1 commit into from
Oct 5, 2020

Conversation

brynmrk
Copy link
Contributor

@brynmrk brynmrk commented Oct 2, 2018

Replaces the functionality wherein nil is already included in the possible options of belongs_to. In the current functionality of administrate, if you add include_blank: true in f.select it would have double blank option in the selections.

Changes in spec/factories.rb where made by running:

rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct

houndci-bot
houndci-bot reviewed Oct 2, 2018
View reviewed changes
spec/lib/fields/belongs_to_spec.rb Outdated Show resolved Hide resolved
spec/features/form_spec.rb Outdated Show resolved Hide resolved
spec/features/form_spec.rb Outdated Show resolved Hide resolved
spec/features/form_spec.rb Outdated Show resolved Hide resolved
spec/features/form_spec.rb Outdated Show resolved Hide resolved
spec/factories.rb Outdated Show resolved Hide resolved
spec/example_app/app/dashboards/customer_dashboard.rb Outdated Show resolved Hide resolved
@nickcharlton nickcharlton added feature new functionality that’s not yet implemented fields new fields, displaying and editing data labels Jan 2, 2020
@nickcharlton
Include_blank in Belongs to form
5084908 
Replaces the functionality wherein nil is already included in the possible
options of belongs_to. In the current functionality of administrate, if you
add `include_blank: true` in f.select it would have double blank option in the
selections.

Changes in spec/factories.rb where made by running:

```
rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct
```
@nickcharlton nickcharlton merged commit 23a5bf4 into thoughtbot:master Oct 5, 2020
@nickcharlton
Copy link
Member

Thanks for opening this!

@tjvc tjvc mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
feature new functionality that’s not yet implemented fields new fields, displaying and editing data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brynmrk @nickcharlton @houndci-bot