Patch Rails 4.2 tests to work with Ruby 2.6. #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue with reusing the `TestResponse` object occurs with Ruby 2.6 and causes `already initialized` exceptions to be thrown. This monkey-patch fixes this for Rails 4.2. It's expected that Rails 4.2 will be dropped by administrate when Rails 6 is released, and this patch should be removed. rails/rails#34790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue with reusing the
TestResponseobject occurs with Ruby 2.6 andcauses
already initializedexceptions to be thrown.This monkey-patch fixes this for Rails 4.2.
It's expected that Rails 4.2 will be dropped by administrate when Rails
6 is released, and this patch should be removed.
rails/rails#34790