Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Portuguese translation #1703

Merged
merged 5 commits into from
Jul 9, 2020
Merged

Conversation

tiagotex
Copy link
Contributor

@tiagotex tiagotex commented Jul 8, 2020

Translated the form key from English in the Portuguese and Portuguese from Brazil translation files.

back_to_app was using an expression used in Portuguese from Brazil that is not used in Portuguese from Portugal.

Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@@ -22,8 +22,8 @@ pt-BR:
more: "Exibindo %{count} de %{total_count}"
none: Nenhum
form:
error: error
errors: "%{pluralized_errors} prohibited this %{resource_name} from being saved:"
error: erro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is dropping the r here deliberate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, erro is the correct translation for error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh huh! Cool, thanks!

tiagotex added 2 commits July 8, 2020 19:31
This sounds better
Use a better translation
@nickcharlton nickcharlton merged commit abfa756 into thoughtbot:master Jul 9, 2020
@nickcharlton nickcharlton added the i18n translations and language support label Jul 9, 2020
@tiagotex tiagotex deleted the patch-1 branch July 9, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n translations and language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants