Argh /tmp/pids #1726
Merged
Argh /tmp/pids #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
approved these changes
Jul 31, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #1718 was merged, it introduced a potential solution to
/tmp/pids/.keepbeing unintentionally deleted. Unfortunately this didn't fix the issue and in fact seems to have made it worse.I think the issue may have been solved already, and it was only surfacing again when moving between commits that included a0eeca6 and those that didn't. I might be wrong though, but at least I was seeing it less now and I think that might have been the pattern.
The changes I'm proposing to gitignore are as currently generated in new Rails apps. Perhaps this will do the trick?