Add extra example for adding controllers without a related model docs #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobm
approved these changes
Aug 31, 2020
janosrusiczki
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first of all I would like to say thank you for all the work done on administrate! It's an awesome project and is being very helpful for me and my team.
About this PR, I was looking into how to setup a custom page without a related model, for example a HELP page and ended up on this doc page which explain very well how to do it. But, I ran into some problems because I didn't have an example on how the controller should look like, so I just "cloned" from a model related one and forgot to overwrite the
indexaction, which took me a couple minutes to find out where the problem was. After digging into the project repository, I found the/spec/example_appfolder and there was this controller example. I hope by adding this extra example to the docs will help other people as well :)