Conditionals mark fields as optional (#1799) #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that application helpers are available throughout the app and the highly specific nature of some of the actions required to determine whether or not a field is required, moving that logic to Field::Base feels more appropriate. This also allows us to add more complex checks to determine whether or not a field is required without exposing that logic everywhere in the application.
nickcharlton
approved these changes
Oct 26, 2020
|
@nickcharlton I think the feature spec is a good call 👍 I'll add it as soon as I find some time. Thanks! |
jmeinerz
force-pushed
the
jm-conditionalrequirement
branch
from
6e94a04 to
9e73c51
Compare
We were assuming that all fields were required when a presence
validation existed. While that makes sense, it's also possible for
validations to be conditional.
Take the following validation as an example:
validates :phone_number, presence: true, if: :egyptian?
Before this commit, the UI would flag phone_number as required, even for
records who were not egyptian.
We now always flag these fields as optional. This is a bit misleading
too, but it's impossible to know these things when the page is rendered,
and marking them as optional makes for a slightly better user interface,
as the user will most likely be prompted with detailed validation errors
after trying to persist an invalid item, rather than be led to fill some
fields that are, in fact, not mandatory.
jmeinerz
force-pushed
the
jm-conditionalrequirement
branch
from
9e73c51 to
f5790b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuming that all fields were required when a presence
validation existed. While that makes sense, it's also possible for
validations to be conditional.
Take the following validation as an example:
Before this commit, the UI would flag phone_number as required, even for
records who were not egyptian.
We now always flag these fields as optional. This is a bit misleading
too, but it's impossible to know these things when the page is rendered,
and marking them as optional makes for a slightly better user interface,
as the user will most likely be prompted with detailed validation errors
after trying to persist an invalid item, rather than be led to fill some
fields that are, in fact, not mandatory.