Select field selected value #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhippenmeyer
force-pushed
the
nch/select-field-selected-value
branch
from
2f17ede to
9be458a
Compare
nhippenmeyer
force-pushed
the
nch/select-field-selected-value
branch
from
9be458a to
cb4a937
Compare
|
Good catch 👍 Would it be possible to add a test? Perhaps a view spec similar to https://github.com/thoughtbot/administrate/blob/cb4a93746e919ba9b3b0db2506e1f049f8feb67e/spec/administrate/views/fields/url/_form_spec.rb |
nhippenmeyer
force-pushed
the
nch/select-field-selected-value
branch
2 times, most recently
from
cc2356b to
f156f9e
Compare
|
@pablobm done! |
nhippenmeyer
force-pushed
the
nch/select-field-selected-value
branch
from
f156f9e to
5846e55
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the select field for a boolean attribute that can be either
true,falseornil, the current behavior causesfalseandnilto be treated the same. If the attribute is set tofalse, the edit dashboard shows the selected value as being theniloption instead offalseas expected.