Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic GitHub Actions CI workflow #1932

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

nickcharlton
Copy link
Member

This is the closest absolute conversation from the original CircleCI 2.0
version as possible. Main differences:

  • Actions' Postgres container requires a password or otherwise doesn't
    start (see SO answer),
  • Ports are explicitly exported,
  • Actions has a stronger, built-in approach to service health,
  • Using the "global" environment variables stops us having to repeat the
    Postgres config multiple times,

https://docs.github.com/en/actions/guides/building-and-testing-ruby
https://docs.github.com/en/actions/guides/creating-postgresql-service-containers
https://docs.github.com/en/actions/reference/environment-variables#about-environment-variables
https://docs.github.com/en/actions/guides/creating-redis-service-containers#running-jobs-directly-on-the-runner-machine
https://stackoverflow.com/a/60618750/83386
https://www.postgresql.org/docs/9.5/libpq-envars.html

@nickcharlton nickcharlton force-pushed the nc-switch-to-github-actions branch 3 times, most recently from 9056cc6 to a15a66d Compare March 10, 2021 10:24
@nickcharlton
Copy link
Member Author

This is currently blocked on us merging thoughtbot/appraisal#174.

@pablobm
Copy link
Collaborator

pablobm commented Apr 29, 2021

Is this something that should be incorporated? #1967

@nickcharlton
Copy link
Member Author

I'm going to do the Dependabot migration before coming back to this (i.e.: today).

@nickcharlton
Copy link
Member Author

This is now back up to date again, using a similar approach to how we've been running appraisals on certain Ruby versions by skipping Rails 6.0 above Ruby 3.0.

I think string comparisons are fine here, but other ideas welcome.


I don't plan to merge this until I've cut a new release of Appraisal, so once that's done our CI checks will take even longer until I disable CircleCI.

@pablobm pablobm added the blocked on dependency Some other PR or issue needs to be addressed before this can label Apr 19, 2023
@nickcharlton nickcharlton force-pushed the nc-switch-to-github-actions branch from a45faa9 to eae80ab Compare September 12, 2023 15:38
@nickcharlton nickcharlton force-pushed the nc-switch-to-github-actions branch 2 times, most recently from 8106d5b to cb44478 Compare December 12, 2023 17:18
@nickcharlton nickcharlton removed the blocked on dependency Some other PR or issue needs to be addressed before this can label Dec 12, 2023
@nickcharlton nickcharlton force-pushed the nc-switch-to-github-actions branch 2 times, most recently from 92fdcce to ea7f726 Compare December 12, 2023 17:37
This is the closest absolute conversation from the original CircleCI 2.0
version as possible. Main differences:

* Actions' Postgres container requires a password or otherwise doesn't
  start (see SO answer),
* Ports are explicitly exported,
* Actions has a stronger, built-in approach to service health,
* Using the "global" environment variables stops us having to repeat the
  Postgres config multiple times,

https://docs.github.com/en/actions/guides/building-and-testing-ruby
https://docs.github.com/en/actions/guides/creating-postgresql-service-containers
https://docs.github.com/en/actions/reference/environment-variables#about-environment-variables
https://docs.github.com/en/actions/guides/creating-redis-service-containers#running-jobs-directly-on-the-runner-machine
https://stackoverflow.com/a/60618750/83386
https://www.postgresql.org/docs/9.5/libpq-envars.html
@nickcharlton nickcharlton force-pushed the nc-switch-to-github-actions branch from ea7f726 to 80f573b Compare December 12, 2023 17:37
@nickcharlton
Copy link
Member Author

Okay, so, 2 years later, I was able to get Appraisal working on GitHub Actions and then do a release. And now I've had enough time to tidy this up and finally merge it.

I'll open a PR soon to remove Circle CI, but it'll be a while before it's gone completely.

@nickcharlton nickcharlton merged commit 17e2774 into main Dec 12, 2023
11 checks passed
@nickcharlton nickcharlton deleted the nc-switch-to-github-actions branch December 12, 2023 17:46
nickcharlton added a commit that referenced this pull request Dec 12, 2023
In #1932, we migrated to GitHub Actions which is generally faster and
has a simpler configuration. This completes that work by removing
Circle CI.

This commit will fail checks for Circle CI, which after it's merged we
can disable in the UI.
@nickcharlton nickcharlton mentioned this pull request Dec 12, 2023
nickcharlton added a commit that referenced this pull request Jan 16, 2024
In #1932, we migrated to GitHub Actions which is generally faster and
has a simpler configuration. This completes that work by removing
Circle CI.

This commit will fail checks for Circle CI, which after it's merged we
can disable in the UI.
nickcharlton added a commit that referenced this pull request Jan 16, 2024
In #1932, we migrated to GitHub Actions which is generally faster and
has a simpler configuration. This completes that work by removing
Circle CI.

This commit will fail checks for Circle CI, which after it's merged we
can disable in the UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants