-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic GitHub Actions CI workflow #1932
Conversation
9056cc6
to
a15a66d
Compare
This is currently blocked on us merging thoughtbot/appraisal#174. |
Is this something that should be incorporated? #1967 |
I'm going to do the Dependabot migration before coming back to this (i.e.: today). |
d028f5a
to
a45faa9
Compare
This is now back up to date again, using a similar approach to how we've been running appraisals on certain Ruby versions by skipping Rails 6.0 above Ruby 3.0. I think string comparisons are fine here, but other ideas welcome. I don't plan to merge this until I've cut a new release of Appraisal, so once that's done our CI checks will take even longer until I disable CircleCI. |
a45faa9
to
eae80ab
Compare
8106d5b
to
cb44478
Compare
92fdcce
to
ea7f726
Compare
This is the closest absolute conversation from the original CircleCI 2.0 version as possible. Main differences: * Actions' Postgres container requires a password or otherwise doesn't start (see SO answer), * Ports are explicitly exported, * Actions has a stronger, built-in approach to service health, * Using the "global" environment variables stops us having to repeat the Postgres config multiple times, https://docs.github.com/en/actions/guides/building-and-testing-ruby https://docs.github.com/en/actions/guides/creating-postgresql-service-containers https://docs.github.com/en/actions/reference/environment-variables#about-environment-variables https://docs.github.com/en/actions/guides/creating-redis-service-containers#running-jobs-directly-on-the-runner-machine https://stackoverflow.com/a/60618750/83386 https://www.postgresql.org/docs/9.5/libpq-envars.html
ea7f726
to
80f573b
Compare
Okay, so, 2 years later, I was able to get Appraisal working on GitHub Actions and then do a release. And now I've had enough time to tidy this up and finally merge it. I'll open a PR soon to remove Circle CI, but it'll be a while before it's gone completely. |
In #1932, we migrated to GitHub Actions which is generally faster and has a simpler configuration. This completes that work by removing Circle CI. This commit will fail checks for Circle CI, which after it's merged we can disable in the UI.
In #1932, we migrated to GitHub Actions which is generally faster and has a simpler configuration. This completes that work by removing Circle CI. This commit will fail checks for Circle CI, which after it's merged we can disable in the UI.
In #1932, we migrated to GitHub Actions which is generally faster and has a simpler configuration. This completes that work by removing Circle CI. This commit will fail checks for Circle CI, which after it's merged we can disable in the UI.
This is the closest absolute conversation from the original CircleCI 2.0
version as possible. Main differences:
start (see SO answer),
Postgres config multiple times,
https://docs.github.com/en/actions/guides/building-and-testing-ruby
https://docs.github.com/en/actions/guides/creating-postgresql-service-containers
https://docs.github.com/en/actions/reference/environment-variables#about-environment-variables
https://docs.github.com/en/actions/guides/creating-redis-service-containers#running-jobs-directly-on-the-runner-machine
https://stackoverflow.com/a/60618750/83386
https://www.postgresql.org/docs/9.5/libpq-envars.html