Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bin/setup #1933

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Update bin/setup #1933

merged 3 commits into from
Mar 9, 2021

Conversation

nickcharlton
Copy link
Member

These are a couple of changes that make bin/setup work well again:

  1. Switch PhantomJS for Chromedriver,
  2. Stop joining the Heroku app, as most people won't,
  3. Drop suggestion/requirement for Foreman.

@nickcharlton
Switch phantomjs for chromedriver
cdee7a4
@nickcharlton
Stop trying to join the Heroku app
dd28e3e 
Heroku keep changing the way this command works and most public users
can't access it anyway.
@nickcharlton
Drop requirement for Foreman
9f44aa7 
You don't need it, so don't push it.
jsilasbailey
jsilasbailey approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@jsilasbailey jsilasbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickcharlton nickcharlton merged commit 32d224a into master Mar 9, 2021
@nickcharlton nickcharlton deleted the nc-update-bin-setup branch March 9, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsilasbailey jsilasbailey jsilasbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickcharlton @jsilasbailey