css: isolate spacing properties for 'button--alt' class #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When customising your own admin dashboards, it is quite expected to use consistent graphical elements (such as buttons) in custom pages. Exposing a `button--alt` CSS class is helpful when adding some custom buttons, however the existing CSS class includes some spacing properties which is specific to the navigation bar (because this class is only used there in the Administrate engine). This commit moves the spacing property (margin) into a dedicated `.button--nav` class in order to give the `.button--alt` class a reusable role.
nickcharlton
approved these changes
Apr 16, 2021
|
Thanks, seems like a good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When customising your own admin dashboards, it is quite expected to
use consistent graphical elements (such as buttons) in custom pages.
Exposing a
button--altCSS class is helpful when adding some custombuttons, however the existing CSS class includes some spacing
properties which is specific to the navigation bar (because this class
is only used there in the Administrate engine).
This PR moves the spacing property (margin) into a dedicated
.button--navclass in order to give the.button--altclass areusable role.