Remove shims that force deprecated form of methods #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobm
force-pushed
the
http-positionals
branch
from
62f277d to
dcdd61a
Compare
pablobm
force-pushed
the
http-positionals
branch
from
dcdd61a to
77470c0
Compare
pablobm
added a commit
to pablobm/administrate
that referenced
this pull request
Jun 17, 2021
These shims were useful when working with Rails 4.2, which we don't
support any more.
Right now, these force us to use a style that is deprecated and triggers
a RuboCop warning Rails/HttpPositionalArguments. Example from the
RuboCop documentation for this rule[1]:
```
get :new, { user_id: 1}
get :new, params: { user_id: 1 }
get :new, **options
```
https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/HttpPositionalArguments
nickcharlton
force-pushed
the
http-positionals
branch
from
77470c0 to
b43b5bc
Compare
nickcharlton
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two spec helper files that provide shims for deprecated forms of some methods:
spec/support/http_method_shims.rbspec/support/controller_helpers.rbThe shims implemented in these were useful when working with Rails 4.2, which we don't support any more.
Right now, they force us to use a style that is deprecated and triggers a RuboCop warning
Rails/HttpPositionalArguments. Example from the RuboCop documentation for this rule[1]:In this PR I remove the shims and convert all usages to the modern form.
[1] https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/HttpPositionalArguments