Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Selenium warning about old options format #2064

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

pablobm
Copy link
Collaborator

@pablobm pablobm commented Nov 19, 2021

After upgrading selenium-webdriver to v4.0.3 at 9e462f7, a new warning has appeared when running the tests:

WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for driver initialization is deprecated. Use :capabilities with an Array of value capabilities/options if necessary instead.

There's not much documentation as to what the options are and how they should be passed here, but this appears to work.
It's based on https://chromedriver.chromium.org/capabilities

@pablobm pablobm force-pushed the update-selenium-options branch 2 times, most recently from 70df3ab to e1d72db Compare November 19, 2021 07:18
@pablobm pablobm requested a review from nickcharlton November 19, 2021 07:18
@pablobm pablobm force-pushed the update-selenium-options branch from e1d72db to 81cb89e Compare December 25, 2021 18:32
No idea of what I'm doing. Documentation is lacking. This seems
to work. It's taken from https://chromedriver.chromium.org/capabilities
@pablobm pablobm force-pushed the update-selenium-options branch from 81cb89e to 681a632 Compare January 13, 2022 17:53
@nickcharlton nickcharlton merged commit 92e6ce4 into thoughtbot:main Jan 24, 2022
@nickcharlton
Copy link
Member

Sure, seems reasonable 🙃

nickcharlton pushed a commit that referenced this pull request Jan 25, 2022
Silences this warning while running "bundle exec rspec":

    WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for
    driver initialization is deprecated. Use :capabilities with an Array of
    value capabilities/options if necessary instead.

But with a cleaner approach from that introduced in #2064.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants