Make search easier to override and adapt to custom use cases #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobm
force-pushed
the
overridable-search
branch
4 times, most recently
from
82dca2e to
a8874f5
Compare
pablobm
force-pushed
the
overridable-search
branch
from
a8874f5 to
699b4b7
Compare
pablobm
force-pushed
the
overridable-search
branch
from
699b4b7 to
43d909b
Compare
18 tasks
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing #2063 made me think about quick ways to customise Administrate's search.
I realised that
Administrate::ApplicationController#indexdoesn't make it easy to override the way that search is performed, so this seems like a first "obvious" port of entry.By factoring out lines 8-10 into their own method, now we can do things like shown in the provided spec. This should be enough for everyone to adapt the search to their own use case.
In the future, we can try rework
Administrate::Orderinto something more configurable and "better". However we all know this is long term future, so this PR should get us going, for a long way, until then.